Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional imagery base map option #1772

Merged
merged 5 commits into from
Jan 10, 2018
Merged

Conversation

Archaejohn
Copy link
Contributor

What has been done to verify that this works as intended?

Tested in Android SDK Emulator

Why is this the best possible solution? Were any other approaches considered?

I attempted to conform to established practices in the codebase. No other approaches have been considered

Are there any risks to merging this code? If so, what are they?

None that I know of, since currently this complies and runs on the emulator.

Do we need any specific form for testing your changes? If so, please attach one.

Change the setting in the menu to OSM SDK and select the new USGS National Map Imagery option for the base map.

I changed the USGS National Map Sat to USGS National Map Hybrid to reduce confusion and be inline with other services offering an imagery basemaps with roads.
@lognaturel lognaturel merged commit 838412c into getodk:master Jan 10, 2018
@lognaturel
Copy link
Member

lognaturel commented Jan 10, 2018

So cool that USGS makes these available.

Another feature you may be interested in is the ability to specify your own offline map tiles -- getodk/docs#3 (it's available now and just needs to be documented)

@Archaejohn
Copy link
Contributor Author

Looks interesting! I started to go down the thought of adding mapquest back in however the user would need to specify their own api key, but I am not sure that is in my time budget right now. I work with GIS a lot and if I come up with any other base map sources I may add them in. There is a TON of federal data available but I think it is important not to bog down the UX with too many base map options.

I may look at seeing how we might be able to with overzoom a layer and still get the tiles at the max zoom level of the server. I think I need to poke osmdroid for this one though. I tried one method I thought of with dismal failure :-(...

@lognaturel
Copy link
Member

lognaturel commented Jan 11, 2018

I think it is important not to bog down the UX with too many base map options.

Yes, agreed.

seeing how we might be able to with overzoom a layer and still get the tiles at the max zoom level of the server.

I noticed there was something not quite right about about deep zoom but didn't have the vocab to talk about it. Consider filing an issue so more brains can look into it! Also, this will start to overlap with some work @jknightco is making at improving all the geo questions so best to loop him into the conversation.

@mathieubossaert
Copy link

mathieubossaert commented Jan 11, 2018

@lognaturel In fact we created a little doc about how to create and use an mbtile offline map. We should translate it for the doc.

@lognaturel
Copy link
Member

That's great, @mathieubossaert! I have a first pass at getodk/docs#545, would be great to get your comments and additions. 😊

shobhitagarwal1612 pushed a commit to shobhitagarwal1612/collect that referenced this pull request May 15, 2018
Changed the USGS National Map Sat to USGS National Map Hybrid to reduce confusion and be inline with other services offering an imagery basemaps with roads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants