2023.4 update deps #975
Merged
2023.4 update deps #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-config-airbnb-base: to fix the peer dependency conflict nodemon: to fix security vulnerabilities (npm audit)
sadiqkhoja
force-pushed
the
2023.4_update_deps
branch
from
f7a80f7
to
c231232
Compare
matthew-white
approved these changes
Sep 13, 2023
lib/data/odata.js
Outdated
| @@ -173,7 +173,7 @@ const submissionToOData = (fields, table, submission, options = {}) => new Promi | |||
| } | |||
|
|
|||
| // bail out without doing any work if we are encrypted. | |||
| if (encrypted === true) return resolve({ data: result, instanceId: submission.instanceId }); | |||
| if (encrypted === true) resolve({ data: result, instanceId: submission.instanceId }); | |||
There was a problem hiding this comment.
Don't we still need to return so that the code below isn't run? Maybe we shouldn't return resolve();, but I'm thinking we should resolve(); return;.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #916 & closes #954
What has been done to verify that this works as intended?
All tests are passing
Why is this the best possible solution? Were any other approaches considered?
I have disabled following rules:
There 500+ errors related to these rules impacting 20+ files, didn't feel we should change those.
I will enable
default-param-lastrule in next release.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Nothing special then existing regression tests
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
No
Before submitting this PR, please make sure you have:
make test-fulland confirmed all checks still pass OR confirm CircleCI build passes