Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittently failing S3 test #1218

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Oct 7, 2024

Hopefully closes #1208

Did a bunch of sleuthing and saw that uploadPending was trying to upload 0 pending blobs. I overlooked aBlobExistsWith at first because I thought it was checking an assertion or something, but when I finally revisited what it was really doing (inserting a blob), I noticed this way in which it could be contributing to failing tests.

This would not have been possible without the previous PR (#1213) to clean up around the tests, so thanks!

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

Copy link
Member

@matthew-white matthew-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. 👍

Copy link
Contributor

@alxndrsn alxndrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 unawaited promises, probably the cause of 50% of test flake

@alxndrsn alxndrsn merged commit 38a7ff0 into master Oct 8, 2024
6 checks passed
@alxndrsn alxndrsn deleted the ktuite/intermittent_test_fail branch October 8, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests hang intermittently
3 participants