Add pgrowlocks to instructions for manually setting up databases #1207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I run tests locally using a database that doesn't have
pgrowlocks
, I see an error message:The instructions here are clear, and tests pass once I create the extension in my test database. However, I think it'd be worth preventing the error by creating the extensions at the time of database setup. The readme includes instructions to manually set up the databases, and this PR adds the
CREATE EXTENSION
statement from above to those instructions.#1190 removed the
CREATE EXTENSION
from the migration, which I think makes a lot of sense. #1190 also removed it from the readme instructions, and that's the part that this PR reverts. The readme instructions are for setting up databases for local development and testing, and I think there's no harm in runningCREATE EXTENSION IF NOT EXISTS
in those environments. The readme instructions already assume that the user is permitted toCREATE USER
andCREATE DATABASE
.lib/bin/create-docker-databases.js also runs
CREATE EXTENSION IF NOT EXISTS pgrowlocks;
. In a sense, this PR is updating the readme to match create-docker-databases.js.Before submitting this PR, please make sure you have:
make test
and confirmed all checks still pass OR confirm CircleCI build passes