Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding promise resolution to createNew audit logger #1180

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Aug 26, 2024

I noticed the same issue I had before come up in a slightly different place: https://staging.getodk.cloud/#/projects/21/forms/cactus_monitoring/submissions/uuid%3A7f406fd6-a7ab-4b7d-9cde-b91e465e56fc

I should probably think of a way to test these tasks better, either with an e2e test, or by doing something to the testing framework. The testing framework currently doesn't let you use the API to set up a test scenario for the cli scripts.

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite merged commit 5b6eb2d into master Aug 27, 2024
5 checks passed
@ktuite ktuite deleted the ktuite/process_backlog_bug branch August 27, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants