Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Filter block_lab_icons broken block with wp 5.3 #476

Open
gfazioli opened this issue Nov 14, 2019 · 2 comments
Open

Filter block_lab_icons broken block with wp 5.3 #476

gfazioli opened this issue Nov 14, 2019 · 2 comments

Comments

@gfazioli
Copy link

gfazioli commented Nov 14, 2019

with wordpress 5.3 my filter

add_filter('block_lab_icons', function ($icons) {
    $myicon = [
        "myicon" => '<svg xmlns="http:\\www.w3.org\2000\svg" width="24" height="24" viewBox="0 0 24 24">....</path></svg>',
    ];

    $icons = array_merge($icons, $myicon);

    return $icons;
});

still works fine, I can see my icon in the BlockLab editor but I cannot see the block when I edit a page. Just remove my icon and all work fine. Any clue?

image

@kienstra
Copy link
Collaborator

kienstra commented Nov 16, 2019

Hi @gfazioli,
Thanks for bringing this up.

'Your site doesn't include support...'

Is there a JS console error or warning when that message appears?

@kienstra
Copy link
Collaborator

Hi @gfazioli,
Hope you're doing great.

Is there still an issue when adding that filter? I hope it's working alright, but I'd like to fix it if there's still an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants