Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

住所の正規化に先立って文字列を Unicode 正規化する #161

Merged
merged 5 commits into from
Feb 4, 2022

Conversation

kamataryo
Copy link
Contributor

related with #160

@kamataryo kamataryo changed the title Add a test with NFKD normalization format syorini Feb 4, 2022
@kamataryo kamataryo changed the title syorini 住所の正規化に先立ってUnicode 正規化する Feb 4, 2022
@kamataryo kamataryo marked this pull request as ready for review February 4, 2022 06:31
@kamataryo kamataryo changed the title 住所の正規化に先立ってUnicode 正規化する 住所の正規化に先立って文字列の Unicode 正規化する Feb 4, 2022
Copy link
Member

@keichan34 keichan34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/normalize

IEは対応していないけど、、まあいいっか。笑

@kamataryo
Copy link
Contributor Author

もともと、main-browser.js のコンパイル結果は ES6 になっているようで、IE では動かなかったですね。 tsconfig.json では target: "es5" なのですが、 @rollup/plugin-commonjs が ES6 に変換しているのかなと思いました。

@kamataryo kamataryo changed the title 住所の正規化に先立って文字列の Unicode 正規化する 住所の正規化に先立って文字列を Unicode 正規化する Feb 4, 2022
@kamataryo kamataryo merged commit 20adfd2 into master Feb 4, 2022
@kamataryo kamataryo deleted the 160-fix-unicode-normalization branch February 4, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants