Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update qgis base image, close #50 #51

Closed
wants to merge 2 commits into from
Closed

Update qgis base image, close #50 #51

wants to merge 2 commits into from

Conversation

Robinlovelace
Copy link
Contributor

No description provided.

@Robinlovelace Robinlovelace linked an issue Aug 2, 2024 that may be closed by this pull request
Use suggests image as basis for qgis image #50
Open
@jannes-m
Copy link
Contributor

jannes-m commented Aug 2, 2024

I think this would only work if the suggests image installs the stuff also installed by the geospatial image, specifically I refer to https://github.com/rocker-org/rocker-versioned2/blob/master/scripts/install_geospatial.sh. However, wouldn't it be easier to just install the missing R libraries bslib and downlilt for the qgis image?

@Robinlovelace
Copy link
Contributor Author

However, wouldn't it be easier to just install the missing R libraries bslib and downlilt for the qgis image?

The thing is that those package are installed in the package, or at least they should be, because the image includes the installation step. So I guess there's something about this bleeding edge image that prevents them being installed: https://hub.docker.com/r/rocker/geospatial/tags

@Robinlovelace
Copy link
Contributor Author

See here:

docker/qgis/Dockerfile

Line 73 in f8aac8a

RUN Rscript -e 'install.packages("geocompkg", repos = c("https://geocompr.r-universe.dev", "https://cloud.r-project.org"), dependencies = TRUE, force = TRUE)'

@Robinlovelace
Copy link
Contributor Author

But yeah, happy NOT to merge this. Maybe we just need to re-run after the new images have been built.

@Robinlovelace
Copy link
Contributor Author

Just testing it with

docker run -it rocker/geospatial:dev-osgeo /bin/bash

@Robinlovelace
Copy link
Contributor Author

Update: there's no need to install those packages because they are already in the qgis image, as shown in the reproducible example below:

docker run -it ghcr.io/geocompx/docker:qgis /bin/bash
root@3867475afea2:/# R

R version 4.2.3 (2023-03-15) -- "Shortstop Beagle"
Copyright (C) 2023 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)

R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.

  Natural language support but running in an English locale

R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.

Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.

> library(bslib)

Attaching package: ‘bslib’

The following object is masked from ‘package:utils’:

    page

@Robinlovelace
Copy link
Contributor Author

Closing as the motivating issue is now fixed I think: geocompx/geocompr@7981e0d

@Robinlovelace Robinlovelace deleted the 50-use-suggests-image-as-basis-for-qgis-image-1 branch August 2, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannes-m jannes-m Awaiting requested review from jannes-m

@Nowosad Nowosad Awaiting requested review from Nowosad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use suggests image as basis for qgis image
2 participants
@Robinlovelace @jannes-m