Modify user agent string for geemap.core #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengalin
commented
Oct 2, 2023
| @@ -122,7 +124,7 @@ def ee_initialize( | |||
| ee.Authenticate(**auth_args) | |||
| ee.Initialize(**kwargs) | |||
|
|
|||
| ee.data.setUserAgent(user_agent) | |||
| ee.data.setUserAgent(user_agent) | |||
There was a problem hiding this comment.
Moved this outside the if ee.data._credentials is None: block so that we re-set the user agent string when there are multiple Maps (it is possible some are core and some are not).
|
Looks like the recent codespell update catches more typos not related to this PR. Merging this now and will fix the typo in another PR. |
giswqs
approved these changes
Oct 2, 2023
|
Should we make a patch release now so that it can be picked up by Colab? @jdbcode |
@naschmitz too |
|
I just made a patch release. @jdbcode mentioned that the Colab team might update the packages around Oct. 4. Hopefully they will pull our latest release that includes this user agent update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.