New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow variable key sizes for Blowfish #933

Merged

a3957273 merged 3 commits into gchq:master from cbeuw:blowfish-keyfix

Mar 31, 2024

Contributor

cbeuw commented Jan 9, 2020

This fixes #930 by correcting the key size validation. Tests have also been added for key sizes other than 8 bytes.

cbeuw added 3 commits

January 9, 2020 15:14


          Fix gchq#930 by allowing variable key sizes

c689cf7


          Add variable key size tests

9e17825


          Grammar typo

81605b2

kevthehermit commented Dec 29, 2021

Any movement on this, its still broken on current release, older versions work as expected

a3957273 approved these changes

View reviewed changes

Member

a3957273 left a comment

Can verify that Blowfish does seem to range from 4 - 56 bytes, not quite sure why it enforced 8 byte keys!

a3957273 merged commit 8647b50 into gchq:master

1 check passed

cbeuw deleted the blowfish-keyfix branch

March 31, 2024 15:58

mwalbeck pushed a commit to mwalbeck/docker-cyberchef that referenced this pull request


          Update dependency gchq/CyberChef to v10.15.1 (#286)

6f5fc35

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [gchq/CyberChef](https://github.com/gchq/CyberChef) | minor | `v10.12.1` -> `v10.15.1` |

---

### Release Notes

<details>
<summary>gchq/CyberChef (gchq/CyberChef)</summary>

### [`v10.15.1`](https://github.com/gchq/CyberChef/releases/tag/v10.15.1)

[Compare Source](gchq/CyberChef@v10.15.0...v10.15.1)

See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details.

### [`v10.15.0`](https://github.com/gchq/CyberChef/releases/tag/v10.15.0)

[Compare Source](gchq/CyberChef@10.14.0...v10.15.0)

See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details.

### [`v10.14.0`](https://github.com/gchq/CyberChef/releases/tag/v10.14.0)

[Compare Source](gchq/CyberChef@10.14.0...10.14.0)

See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details.

### [`v10.14.0`](https://github.com/gchq/CyberChef/blob/HEAD/CHANGELOG.md#10140---2024-03-31)

[Compare Source](gchq/CyberChef@v10.13.0...10.14.0)

-   Added 'To Float' and 'From Float' operations \[[@&#8203;tcode2k16](https://github.com/tcode2k16)] | \[[#&#8203;1762](gchq/CyberChef#1762)]
-   Fix ChaCha raw export option \[[@&#8203;joostrijneveld](https://github.com/joostrijneveld)] | \[[#&#8203;1606](gchq/CyberChef#1606)]
-   Update x86 disassembler vendor library \[[@&#8203;evanreichard](https://github.com/evanreichard)] | \[[#&#8203;1197](gchq/CyberChef#1197)]
-   Allow variable Blowfish key sizes \[[@&#8203;cbeuw](https://github.com/cbeuw)] | \[[#&#8203;933](gchq/CyberChef#933)]
-   Added 'XXTEA' operation \[[@&#8203;devcydo](https://github.com/devcydo)] | \[[#&#8203;1361](gchq/CyberChef#1361)]

### [`v10.13.0`](https://github.com/gchq/CyberChef/releases/tag/v10.13.0)

[Compare Source](gchq/CyberChef@v10.12.1...v10.13.0)

See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMyIsInVwZGF0ZWRJblZlciI6IjM3LjI3OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Reviewed-on: https://git.walbeck.it/mwalbeck/docker-cyberchef/pulls/286
Co-authored-by: renovate-bot <bot@walbeck.it>
Co-committed-by: renovate-bot <bot@walbeck.it>

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet