Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Gzip comment not working #870

Closed
zehuanli opened this issue Nov 3, 2019 · 1 comment
Closed

Bug report: Gzip comment not working #870

zehuanli opened this issue Nov 3, 2019 · 1 comment

Comments

@zehuanli
Copy link

zehuanli commented Nov 3, 2019

Describe the bug
Very minor bug, but it would be great if this could be fixed:

The Gzip encoder has an optional Comment field that allows users to supply comment. (Documented in rfc1952, see FCOMMENT). It is implemented in Gzip.mjs but there's a typo - "options.flags.fcommenct" should actually be "options.flags.fcomment", as I assume from the context.

To Reproduce

  1. Open CyberChef
  2. Select Gzip operation and deflate some text, save the output (better as hex).
  3. Put something in the Comment field, compare the new output with the one in previous step.
  4. Observe that the comment was not put into the deflated data. (Although the new output will be different because different timestamps are used).

Expected behaviour
The text in the Comment field should present in the deflated data.

Desktop (if relevant, please complete the following information):

  • CyberChef version: [9.9.0]
@n1474335
Copy link
Member

Fixed in #926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants