-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug report: screen reader and keyboard users can't actually implement/select operations #1819
Comments
Hi! Sorry to hear you're having trouble - I've just had a try on my end, and am able to add operations after a search by using the arrow keys. Pressing "down" after searching (with my cursor focus still in the search box) highlights the first item in the list, and repeated presses select the next and so on. Pressing "enter" adds it to the recipe at the end. Could you give this a try and let us know if it works? Could absolutely be better though, it's a bit fiddly to get right. |
@mattnotmitt I just tried this and that does appear to work. The one problem here is that screen readers don't track focus once that autocomplete list opens, e.g. screen readers only focus one thing at a time, and when hitting down arrow in the search field, the focus is sstill going to be on the search field rather than the newly opened dropdown.
The easiest way to solve this is generally by using an aria property called activedescendant: https://developer.mozilla.org/en-US/docs/web/Accessibility/ARIA/Attributes/aria-activedescendant If for whatever reason this can't be implemented, an alternative is using an aria-live widget to communicate the currently selected operation. Some caveats:
I hope this helps. I'd love to actually be able to use this in my cybersecurity endeavors :) |
Thank you for the in-depth descriptions! I'll have a stab at implementing this shortly :) |
No probs, let me know if anything needs testing, happy to look at a codepen or similar :) |
I've deployed my work-in-progress version of this on my fork: https://mattnotmitt.github.io/CyberChef |
This is much better already :) Very usable like this. If it doesn't reak anything visually I'd say go ahead and merge. |
Describe the bug
A clear and concise description of what the bug is.
In my testing, I have not found a way, even with simulating mouse clicks, to actually add an operation to a recipe.
To Reproduce
Steps to reproduce the behaviour or a link to the recipe / input used to cause the bug:
Expected behaviour
A clear and concise description of what you expected to happen.
I should be able to use keyboard and/or screen reader commands to "pick" an operation to perform.
Additional context
I see some attention was drawn to this already by #1718 and that a bunch of things were already fixed, this is good. I'm just intending to highlight here that this, while probably challenging, is also the main problem for a lot of people. As a screen reader user, having labels for things is helpful for sure but it ultimately doesn't add much if the core functionality of the tool remain unusable :)
Is there any other way to add an operation to a recipe apart from dragging it? If not, that right there is going to have to be solved before any other fixes really provide much of an impact.
Easiest way I can think of is to just make a click event append a step to the current recipe, that way screen readers should already be able to get a lot further. Ultimately though, being able to navigate this using the keyboard and pressing enter or some other key to do the same thing will need to be added. I'd love to hear thoughts on this.
Disclaimer: fully blind coder, hacker, accessibility consultant, AMA, yadda yadda.
The text was updated successfully, but these errors were encountered: