Fix Ciphersaber2 key concatenation #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concat method does not handle typed arrays as arguments.
a3957273
approved these changes
Apr 1, 2024
| @@ -4,7 +4,7 @@ | |||
| * @license Apache-2.0 | |||
| */ | |||
| export function encode(tempIVP, key, rounds, input) { | |||
| const ivp = new Uint8Array(key.concat(tempIVP)); | |||
| const ivp = new Uint8Array([...key, ...tempIVP]); | |||
There was a problem hiding this comment.
key is a number[] and tempIVP is a Buffer, so I was initially surprised that they can't be concatenated, but a quick test shows it's true:
> const tempIVP = Buffer.from([1, 2])
undefined
> const key = [3, 4]
undefined
> key.concat(tempIVP)
[ 3, 4, <Buffer 01 02> ]An alternative seems to be spreading just the buffer (e.g. key.concat(...tempIVP)), but explicitly spreading both seems like a nicer solution anyway. Nice catch!
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the generated key was invalid because an Uint8Array was concatenated into a normal array but that wasn't supported by the concat function.
Effectively the IV was discarded so the cipher did not work :)
This should fix #1723