Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated jsonwebtoken dependency to 9+ #1753

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

chriswhite199
Copy link
Contributor

As per npm audit, jwonwebtoken has a moderate level vuln:

jsonwebtoken  <=8.5.1
Severity: moderate
jsonwebtoken unrestricted key type could lead to legacy keys usage  - https://github.com/advisories/GHSA-8cf7-32gw-wr33
jsonwebtoken's insecure implementation of key retrieval function could lead to Forgeable Public/Private Tokens from RSA to HMAC - https://github.com/advisories/GHSA-hjrf-2m68-5959
jsonwebtoken vulnerable to signature validation bypass due to insecure default algorithm in jwt.verify() - https://github.com/advisories/GHSA-qwph-4952-7xr6
fix available via `npm audit fix --force`
Will install jsonwebtoken@9.0.2, which is a breaking change
node_modules/jsonwebtoken

This PR:

  • Updates jsonwebtoken to latest 9+ version
  • Updates JWTSign operation for backwards compatibility with insecure keys and invalid asym key types

As a future feature suggestion, add the insecure / invalid key flags as options to the module

updated JWTSign operation for backwards compatibility with insecure keys and invalid asym key types
@a3957273
Copy link
Member

Thanks for the contribution. ❤️

@a3957273 a3957273 merged commit 6edf731 into gchq:master Mar 29, 2024
4 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants