Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: SOSEMANUK, Salsa Variants, ChaCha Variants, HC-256, HC-128, RC5, RC6, TEA, XTEA #1603

Closed
stevemk14ebr opened this issue Jul 18, 2023 · 6 comments
Labels

Comments

@stevemk14ebr
Copy link

stevemk14ebr commented Jul 18, 2023

Is your feature request related to a problem? Please describe.
The ciphers SOSEMANUK, Salsa, ChaCha8, ChaCha12, HC-256, HC-128, RC5, RC6, TEA, XTEA are all currently missing, but are ones I have seen used in malware at one point or another or are otherwise popular.

Describe the solution you'd like
Please consider adding support for these ciphers

Describe alternatives you've considered
Using other tools or creating custom one off decoders is the current workaround

Additional context
ChaCha variants: https://cr.yp.to/chacha.html vary in the internal number of rounds they compute

The Salsa20 directory in version 2008.01.20 of the eSTREAM benchmarking suite includes several implementations of ChaCha8 (and ChaCha12 and ChaCha20): 

Reference
ChaCha8: https://cr.yp.to/streamciphers/timings/estreambench/submissions/salsa20/chacha8/ref/chacha.c
ChaCha12: https://cr.yp.to/streamciphers/timings/estreambench/submissions/salsa20/chacha12/ref/chacha.c
ChaCha20: https://cr.yp.to/streamciphers/timings/estreambench/submissions/salsa20/chacha20/ref/chacha.c
Salsa20: https://cr.yp.to/snuffle/salsa20/ref/salsa20.c

Salsa 20/8 and Salsa 20/12 variants:
https://cr.yp.to/snuffle/812.pdf

I could not find a reference implementation for these variants, but exactly like chacha variants. They only vary in the number of internal rounds. Please also include the variants with differing rounds or make it a parameter which defaults to 20.

SOSEMANUK: https://www.ecrypt.eu.org/stream/e2-sosemanuk.html
TEA: https://en.wikipedia.org/wiki/Tiny_Encryption_Algorithm
XTEA: https://en.wikipedia.org/wiki/XTEA

@stevemk14ebr stevemk14ebr changed the title Feature request: Salsa, ChaCha8, ChaCha12, HC-256, HC-128, RC5, RC6 Feature request: SOSEMANUK, Salsa, ChaCha8, ChaCha12, HC-256, HC-128, RC5, RC6, TEA, XTEA Jul 19, 2023
@stevemk14ebr stevemk14ebr changed the title Feature request: SOSEMANUK, Salsa, ChaCha8, ChaCha12, HC-256, HC-128, RC5, RC6, TEA, XTEA Feature request: SOSEMANUK, Salsa Variants, ChaCha Variants, HC-256, HC-128, RC5, RC6, TEA, XTEA Jul 19, 2023
@Still34
Copy link

Still34 commented Feb 21, 2024

Was gonna check if there was already a feature request for TEA - TEA/ChaCha/Salsa are sorely missing in CyberChef and would be excellent additions otherwise.

@joostrijneveld
Copy link
Contributor

joostrijneveld commented Mar 11, 2024

Note that ChaCha8 and ChaCha12 are already available through the ChaCha operation; you can set the round number from 20 to 12 or 8. Or am I overlooking something in your request?

@stevemk14ebr
Copy link
Author

ChaCha is present yea, the others are not though

@a3957273
Copy link
Member

@stevemk14ebr Salsa, ChaCha and XXTea are now present in the application. Would you be willing to break the others out into separate issues? It should make it easier for people to contribute individual features, ❤️ .

@stevemk14ebr
Copy link
Author

Sure! Give me a few days please and I will. Thank you!!

@stevemk14ebr
Copy link
Author

stevemk14ebr commented Apr 3, 2024

Done, please see:

TEA & XTEA: #1774
SOSEMANUK: #1775
HC-256 & HC-128: #1776
RC5 & RC6: #1777

I grouped like algos together for lower overhead, even though they're distinct in some cases. There's probably a few more, but these are the major ones IMHO at least. Thanks for adding the ones you have already, note that XXTEA, XTEA, and TEA all are distinct.

Additional:
PRESENT: #1778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants