-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the term "keys" in input routine #72
Comments
If it matters: The main reason I used "keys" is because the NES is the first console platform that I learned circa 2000 after having learned the Allegro library, and I carried the habit with me to GBA, my second console platform. Also libtonc, the GBA counterpart to hardware.inc, uses "keys" all over. Its |
As a counterexample: pret/pokecrystal uses “Joy” or “Buttons” depending on the context, but never “Keys”. |
I think "keys" is more meaningful, at least as a teaching tool, as it hints at the low-level nature of reading input on the Game Boy. It's a long way from what most game developers would usually be doing (on any other major platform since the mid-late 90s) i.e. data packets on a serial bus, if not much more high-level 'events'. A "key" is a momentary switch. Also, as you noted, "key" applies to both groups of inputs -- directions and buttons. They are all keys/switches and identical electr(on)ically. Anyway, if it were to be changed, I think "buttons" (e.g. To
|
I wonder if a more console-focused term such as "buttons" could be used instead of "keys" for the following-
From what I can tell the comments in the code itself uses the word "buttons" and "directions" to refer to the face buttons and d-pad and that "keys" are meant to encompass both of these but I still feel like it's a word not quite suited for the purpose.
The text was updated successfully, but these errors were encountered: