Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gz sdf command on windows #1344

Closed
wants to merge 2 commits into from

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Nov 10, 2023

🦟 Bug fix

Fixes #1321

Summary

#1339 fixed some issues related to the gz tool on windows, but as mentioned in #1339 (comment), the UNIT_gz_TEST weren't running.

Needs gazebo-tooling/release-tools#1063

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from scpeters as a code owner November 10, 2023 04:45
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 10, 2023
@azeey
Copy link
Collaborator Author

azeey commented Nov 10, 2023

Build using gazebo-tooling/release-tools#1063: Build Status

@azeey azeey self-assigned this Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #1344 (35c5b89) into sdf13 (24b6153) will not change coverage.
The diff coverage is n/a.

❗ Current head 35c5b89 differs from pull request most recent head 9b730b5. Consider uploading reports for the commit 9b730b5 to get more accurate results

@@           Coverage Diff           @@
##            sdf13    #1344   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files         128      128           
  Lines       17090    17090           
=======================================
  Hits        14968    14968           
  Misses       2122     2122           
Files Coverage Δ
src/Console.cc 87.93% <ø> (ø)

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green. Nice!

@azeey
Copy link
Collaborator Author

azeey commented Nov 10, 2023

CI is green. Nice!

Unfortunately not. The CI that actually runs the UNIT_gz_TESt is https://build.osrfoundation.org/job/sdformat-pr-win/792/ and it's failing.

@ahcorde
Copy link
Collaborator

ahcorde commented Nov 10, 2023

Then Github is not properly updated
a

@azeey
Copy link
Collaborator Author

azeey commented Nov 10, 2023

Then Github is not properly updated a

That is showing builds with the master branch of release-tools. This PR needs gazebo-tooling/release-tools#1063 merged for it to show up on the github checks. I manually ran https://build.osrfoundation.org/job/sdformat-pr-win/792/ to use the branch from gazebo-tooling/release-tools#1063 to test before merging.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Copy link
Collaborator Author

azeey commented Apr 19, 2024

More complete fix in #1374. Will partially backport that once merged.

@azeey azeey closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz sdf still not on Windows?
2 participants