Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a compile definition for setting GZ_CONFIG_PATH #1341

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Use a compile definition for setting GZ_CONFIG_PATH #1341

merged 1 commit into from
Oct 17, 2023

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Oct 17, 2023

Suggestion for #1339

@azeey
Use a compile definition for setting GZ_CONFIG_PATH
0d34a61 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from scpeters as a code owner October 17, 2023 15:52
@azeey azeey requested a review from Voldivh October 17, 2023 15:52
Voldivh
Voldivh approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@Voldivh Voldivh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like this solution a lot more.

@azeey azeey mentioned this pull request Oct 17, 2023
Open
@Voldivh Voldivh merged commit 6903169 into gazebosim:voldivh/win_install_cmd Oct 17, 2023
7 of 9 checks passed
@scpeters scpeters mentioned this pull request Jun 13, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Voldivh Voldivh Voldivh approved these changes

@scpeters scpeters Awaiting requested review from scpeters

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @Voldivh