Add camera optical_frame_id element #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marqrazz <marq.razz@gmail.com>
MarqRazz
force-pushed
the
pr_optical_frame
branch
from
c3218a2
to
bdf731e
Compare
9 tasks
Signed-off-by: marqrazz <marq.razz@gmail.com>
MarqRazz
force-pushed
the
pr_optical_frame
branch
from
5705bb6
to
0ead856
Compare
|
Sorry about the force pushes, I'm not use to the DCO workflow. |
ahcorde
approved these changes
Aug 24, 2022
Codecov Report
@@ Coverage Diff @@
## sdf12 #1109 +/- ##
=======================================
Coverage 91.66% 91.67%
=======================================
Files 80 80
Lines 13028 13039 +11
=======================================
+ Hits 11942 11953 +11
Misses 1086 1086
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Just checking in to see if there is anything I can help with here. I would like to get this merged soon if possible, I have a project that depends on the work and would like to get this into the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
This adds the ability to specify the
optical frame_idthat will be used when publishing the camera_info topic from a simulated sensor. This feature request was noted in CameraSensors.cc and will help close gazebosim/gz-sensors#175 in ign-sensors.Summary
Adds optional sdf element
optical_frame_idthat the simulated camera can utilize. I will make a PR in ign-sensors to utilize the new element after this PR is merged.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.