Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
While releasing
ros_ign
for Rolling, I noticed pretty late during the release process that bloom doesn't respect local conditionals, see ros-infrastructure/bloom#517.I was using the
ros2
branch to release. That branch supported both Foxy and Rolling. Foxy is supposed to be released with Citadel, and Rolling (future Galactic) with Edifice. For that reason, the branch would default to Citadel ifIGNITION_VERSION
was not set. The problem is that there was no way to pass the env var to bloom to tell it to release with Edifice for Rolling.The quickest solution right now is branching off for Rolling. I created a new
foxy
branch off the last commit before I created the changelog for the rolling release.This PR flips the default on the
ros2
branch from Citadel to Edifice. Once this is merged, I'll rerun bloom-release.CC @nuclearsandwich
Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸