Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps in garden : ign-cmake3, ign-utils2 #49

Merged
merged 5 commits into from
Apr 8, 2022
Merged

Bumps in garden : ign-cmake3, ign-utils2 #49

merged 5 commits into from
Apr 8, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon
Bumps in garden : ign-utils2
2b5a1b9 
Signed-off-by: Brandon Ong <brandon@openrobotics.org>
@methylDragon methylDragon requested a review from azeey as a code owner April 6, 2022 22:55
@methylDragon methylDragon changed the title Bumps in garden : ign-utils2 Bumps in garden : ign-cmake3, ign-utils2 Apr 6, 2022
chapulina
chapulina suggested changes Apr 6, 2022
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@chapulina
Copy link
Contributor

@osrf-jenkins run tests please

@chapulina
3.0.0
a0d56f4 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
chapulina approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed the 3.0.0 change in a0d56f4. We can merge once CI is green. And once we merge this, we should merge all related PRs together.

This was referenced Apr 7, 2022
Merged
Merged
Merged
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please

@methylDragon
Copy link
Contributor Author

Reran with nightlies built here https://build.osrfoundation.org/job/ign-cmake3-debbuilder/4/

I think it's failing because it's looking for version 3.0.0, but the nightlies are on 2.999.999.....

@methylDragon
Copy link
Contributor Author

Can we do an interim of 2.999.999 on the file first, or should we bump the nightly version?

@methylDragon
Copy link
Contributor Author

methylDragon commented Apr 7, 2022 •
edited
Loading

I will try to remove the version and see what happens 🤞

Edit, nope :( reverted

@methylDragon
Copy link
Contributor Author

methylDragon commented Apr 7, 2022 •
edited
Loading

I think it's because the nightlies releasing cmake3 from the ign-cmake2 branch (https://build.osrfoundation.org/job/ignition-garden-nightly-scheduler/164/console), which has the project name set as ign-cmake2 (https://github.com/ignitionrobotics/ign-cmake/blob/ign-cmake2/CMakeLists.txt#L6)

I will try with a proper configuration this time.

@chapulina
Copy link
Contributor

I think it's because the nightlies releasing cmake3 from the ign-cmake2 branch

Oh I just saw this comment, and I had just triggered a couple of nightlies before: https://build.osrfoundation.org/job/ign-cmake3-debbuilder/

@methylDragon
Copy link
Contributor Author

Removed the version again after the nightlies were regenerated. More CI is passing!!

chapulina
chapulina approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 🟢 !

@methylDragon methylDragon merged commit ec4decb into main Apr 8, 2022
@methylDragon methylDragon deleted the ci_matching_branch/bump_garden_ign-utils2 branch April 8, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters left review comments

@chapulina chapulina chapulina approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methylDragon @chapulina @scpeters