Change an entities visual material color by topic. #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2024
ahcorde
requested changes
Jan 15, 2024
bperseghetti
force-pushed
the
pr-material_color
branch
from
f05004a
to
cfb0d74
Compare
ahcorde
added
the
needs upstream release
ahcorde
requested changes
Jan 16, 2024
bperseghetti
force-pushed
the
pr-material_color
branch
3 times, most recently
from
43578d8
to
fc67f1d
Compare
7 tasks
bperseghetti
force-pushed
the
pr-material_color
branch
from
f83c0ea
to
763e2a3
Compare
7 tasks
|
@osrf-jenkins run tests please |
bperseghetti
force-pushed
the
pr-material_color
branch
2 times, most recently
from
7511b61
to
7e62928
Compare
|
@osrf-jenkins run tests please |
This change allows for a simpler mapping from MaterialColor msg to the much more cumbersome Visual msg, allong for users to rapidly change the colors of a entities visual material color components. This is especially useful for simulating status lighting. Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
bperseghetti
force-pushed
the
pr-material_color
branch
from
7e62928
to
4df3989
Compare
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
bperseghetti
force-pushed
the
pr-material_color
branch
from
4df3989
to
0e23d42
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## gz-sim8 #2286 +/- ##
===========================================
+ Coverage 65.79% 65.92% +0.13%
===========================================
Files 327 327
Lines 31212 31285 +73
===========================================
+ Hits 20536 20625 +89
+ Misses 10676 10660 -16 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
8 tasks
7 tasks
|
@osrf-jenkins run tests please |
azeey
removed
the
needs upstream release
azeey
requested changes
Jan 22, 2024
Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
bperseghetti
force-pushed
the
pr-material_color
branch
from
571292d
to
89a6367
Compare
Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
bperseghetti
force-pushed
the
pr-material_color
branch
from
9167621
to
22f1c02
Compare
|
@ahcorde mind taking a quick look? |
ahcorde
approved these changes
Jan 25, 2024
Thanks for the code review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This change allows for a simpler mapping from MaterialColor msg in gz to the much more cumbersome Visual msg. By doing this and adding a topic listener it allows users to rapidly change the colors of a entities visual material color components, including from the ROS side using the gz bridge. This is especially useful for simulating status lighting.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.