Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pose3d with common widget pose #1571

Merged
merged 9 commits into from
Jul 14, 2022

Conversation

AzulRadio
Copy link
Contributor

@AzulRadio AzulRadio commented Jul 1, 2022

New feature

Summary

Implement Pose in Component Inspector with common widget GzPose introduced in gz-gui#424.

Behavior should be exactly the same as before.

image

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

AzulRadio and others added 5 commits June 21, 2022 15:50
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1571 (f33621e) into ign-gazebo3 (abe0ff6) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gazebo3    #1571   +/-   ##
============================================
  Coverage        77.76%   77.76%           
============================================
  Files              250      250           
  Lines            14443    14443           
============================================
  Hits             11231    11231           
  Misses            3212     3212           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe0ff6...f33621e. Read the comment docs.

@chapulina chapulina added GUI Gazebo's graphical interface (not pure Ignition GUI) 🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience labels Jul 1, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jul 1, 2022
@chapulina chapulina requested a review from jennuine July 1, 2022 22:39
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio marked this pull request as ready for review July 7, 2022 19:22
@AzulRadio AzulRadio requested a review from chapulina as a code owner July 7, 2022 19:22
@jennuine jennuine mentioned this pull request Jul 13, 2022
5 tasks
@jennuine jennuine removed the needs upstream release Blocked by a release of an upstream library label Jul 14, 2022
@ahcorde ahcorde merged commit df45262 into ign-gazebo3 Jul 14, 2022
@ahcorde ahcorde deleted the azulradio/common_widget_pose branch July 14, 2022 19:58
@scpeters
Copy link
Member

are there any plans to port this change to fortress? there are conflicts when I try to merge this forward, and I'm not sure how to resolve them

@AzulRadio
Copy link
Contributor Author

@scpeters Fortress has a plotting feature for pose that is not supported in Citadel so there are conflicts when you forward-port. I am working a PR in gz-gui6 to add the feature and after a release for gui6 we should be good to forward-port.

@scpeters
Copy link
Member

@scpeters Fortress has a plotting feature for pose that is not supported in Citadel so there are conflicts when you forward-port. I am working a PR in gz-gui6 to add the feature and after a release for gui6 we should be good to forward-port.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel GUI Gazebo's graphical interface (not pure Ignition GUI) OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants