5 ➡️ 6 #1199
Merged
5 ➡️ 6 #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for dynamic setting of joint limits (position, velocity and effort). Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Adds support for tracked vehicles along the lines of https://osrf-migration.github.io/gazebo-gh-pages/#!/osrf/gazebo/pull-requests/2652/page/1 . It is based on M. Pecka, K. Zimmermann and T. Svoboda, "Fast simulation of vehicles with non-deformable tracks," 2017 IEEE/RSJ International Conference on Intelligent Robots and Systems (IROS), 2017, pp. 6414-6419, doi: 10.1109/IROS.2017.8206546. Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
) Spurious <plugin> elements were created when saving worlds because sdf::Element::GetElement was used to check if a <plugin> child element exists. However this function always creates a new element if the element does not exist instead of returning a nullptr. The solution is to use sdf::Element::FindElement instead. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1199 +/- ##
===============================================
+ Coverage 61.47% 61.88% +0.40%
===============================================
Files 268 274 +6
Lines 21626 22441 +815
===============================================
+ Hits 13294 13887 +593
- Misses 8332 8554 +222
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Jasmeet Singh <jasmeet0915@gmail.com>
chapulina
force-pushed
the
chapulina/5_to_6
branch
from
949e88a
to
cff043e
Compare
azeey
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-gazebo5toign-gazebo6Branch comparison: ign-gazebo6...gazebo5
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)