Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved noise coverage #278

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Improved noise coverage #278

merged 2 commits into from
Oct 26, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 26, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 Code coverage

Summary

Improved noise coverage

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from iche033 as a code owner October 26, 2022 16:28
@ahcorde ahcorde self-assigned this Oct 26, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #278 (a3e3c05) into ign-sensors3 (c754e21) will increase coverage by 0.67%.
The diff coverage is n/a.

❗ Current head a3e3c05 differs from pull request most recent head 0ce7e36. Consider uploading reports for the commit 0ce7e36 to get more accurate results

@@               Coverage Diff                @@
##           ign-sensors3     #278      +/-   ##
================================================
+ Coverage         77.57%   78.24%   +0.67%     
================================================
  Files                23       23              
  Lines              2377     2377              
================================================
+ Hits               1844     1860      +16     
+ Misses              533      517      -16     
Impacted Files Coverage Δ
src/Noise.cc 100.00% <0.00%> (+26.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll self-requested a review October 26, 2022 20:25
@mjcarroll
Copy link
Contributor

I think the bionic failure here may be a race condition in the test.

@mjcarroll
Copy link
Contributor

Windows warnings should be fixed by #279

@mjcarroll mjcarroll enabled auto-merge (squash) October 26, 2022 20:47
@mjcarroll mjcarroll merged commit 4a99c5f into ign-sensors3 Oct 26, 2022
@mjcarroll mjcarroll deleted the ahcorde/3/coverage_noise branch October 26, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants