Add support for 16 bit image format #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-sensors6 #276 +/- ##
================================================
+ Coverage 72.16% 72.20% +0.04%
================================================
Files 34 34
Lines 3470 3483 +13
================================================
+ Hits 2504 2515 +11
- Misses 966 968 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahcorde
approved these changes
Sep 27, 2022
mjcarroll
approved these changes
Sep 27, 2022
|
CIs are failing because of the bump of sdformat dep requirement to 12.6.0 in #259. We need to make a stable sdformat 12.6.0 release. |
|
@osrf-jenkins run tests please |
|
@iche033 @mjcarroll Awesome! Just what I've been looking for! Has this already hit the binaries in release yet? |
|
Also closes #1736. |
|
Not yet, but should be included in the next minor release, 6.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org
🎉 New feature
Closes #275
Summary
Add check for 16 bit image format. This should already be supported at the gz-rendering library. It's just a matter of enabling it in gz-sensors.
You can also test with
sensors_demo.sdfworld. Change one of the cameras to output 16 bit images by adding<format>L_INT16</format>here. You should grayscale images in the top left Image Display GUI pluginTest it
Run
INTEGRATION_cameratestChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.