Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for ShaderType, GraphicsAPI, and DistortionPass #671

Merged
merged 5 commits into from
Jul 23, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 14, 2022

🦟 Bug fix

Summary

Added unit tests for ShaderType, GraphicsAPI, and DistortionPass, which currently have zero or very low test coverage.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 14, 2022
@iche033 iche033 added tests Broken or missing tests / testing infra QA Quality assurance. labels Jul 14, 2022
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #671 (67a24cc) into ign-rendering6 (a8e06ae) will increase coverage by 0.10%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           ign-rendering6     #671      +/-   ##
==================================================
+ Coverage           54.92%   55.03%   +0.10%     
==================================================
  Files                 202      202              
  Lines               21102    21102              
==================================================
+ Hits                11591    11614      +23     
+ Misses               9511     9488      -23     
Impacted Files Coverage Δ
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️
src/ShaderType.cc 100.00% <0.00%> (+87.50%) ⬆️
src/GraphicsAPI.cc 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e06ae...67a24cc. Read the comment docs.

src/GraphicsAPI_TEST.cc Outdated Show resolved Hide resolved
src/ShaderType_TEST.cc Outdated Show resolved Hide resolved
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from ahcorde July 21, 2022 23:03
@chapulina chapulina added the bug Something isn't working label Jul 23, 2022
@chapulina chapulina merged commit 064e808 into ign-rendering6 Jul 23, 2022
@chapulina chapulina deleted the src_unit_tests branch July 23, 2022 04:22
@iche033 iche033 restored the src_unit_tests branch July 25, 2022 18:07
@iche033 iche033 deleted the src_unit_tests branch July 25, 2022 18:07
@iche033 iche033 mentioned this pull request Oct 12, 2022
9 tasks
@ahcorde ahcorde mentioned this pull request Oct 12, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏯 fortress Ignition Fortress QA Quality assurance. tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants