-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for ShaderType, GraphicsAPI, and DistortionPass #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
iche033
added
tests
Broken or missing tests / testing infra
QA
Quality assurance.
labels
Jul 14, 2022
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #671 +/- ##
==================================================
+ Coverage 54.92% 55.03% +0.10%
==================================================
Files 202 202
Lines 21102 21102
==================================================
+ Hits 11591 11614 +23
+ Misses 9511 9488 -23
Continue to review full report at Codecov.
|
ahcorde
previously requested changes
Jul 14, 2022
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
chapulina
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
🏯 fortress
Ignition Fortress
QA
Quality assurance.
tests
Broken or missing tests / testing infra
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Added unit tests for ShaderType, GraphicsAPI, and DistortionPass, which currently have zero or very low test coverage.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.