6 ➡️ 7 (main) #507
Merged
6 ➡️ 7 (main) #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix selection buffer crash due to resize and incorrect selections Signed-off-by: Ian Chen <ichen@osrfoundation.org> * test updating full selection buffer texture Signed-off-by: Ian Chen <ichen@osrfoundation.org> * reenable visual at test Signed-off-by: Ian Chen <ichen@osrfoundation.org> * fix codecheck Signed-off-by: Ian Chen <ichen@osrfoundation.org> * testing rgb no depth, full buffer Signed-off-by: Ian Chen <ichen@osrfoundation.org> * use 1x1 buffer, still no depth data Signed-off-by: Ian Chen <ichen@osrfoundation.org> * prnt scaling factor Signed-off-by: Ian Chen <ichen@osrfoundation.org> * disable device ratio Signed-off-by: Ian Chen <ichen@osrfoundation.org> * reenable depth and utils test Signed-off-by: Ian Chen <ichen@osrfoundation.org> * disable utils test, add visual at test after resize Signed-off-by: Ian Chen <ichen@osrfoundation.org> * test texelfetch Signed-off-by: Ian Chen <ichen@osrfoundation.org> * back to full buffer Signed-off-by: Ian Chen <ichen@osrfoundation.org> * print ogre log Signed-off-by: Ian Chen <ichen@osrfoundation.org> * codecheck Signed-off-by: Ian Chen <ichen@osrfoundation.org> * fixing selection buffer mat script Signed-off-by: Ian Chen <ichen@osrfoundation.org> * try 1x1 buffer again Signed-off-by: Ian Chen <ichen@osrfoundation.org> * revert some test changes Signed-off-by: Ian Chen <ichen@osrfoundation.org> * uncomment tests Signed-off-by: Ian Chen <ichen@osrfoundation.org> * update scaling factor Signed-off-by: Ian Chen <ichen@osrfoundation.org> * fix removing selection mat Signed-off-by: Ian Chen <ichen@osrfoundation.org> * update screenScalingFactor Signed-off-by: Ian Chen <ichen@osrfoundation.org> * minor tweak Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
#498) - Add new param colorTexResolution to the selection buffer shader - Implement the Metal equivalent of texelFetch in the shaders Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
* partial fix for emissive map Signed-off-by: Ian Chen <ichen@osrfoundation.org> * convert grayscale emissive to rgb Signed-off-by: Ian Chen <ichen@osrfoundation.org> * testing upload Signed-off-by: Ian Chen <ichen@osrfoundation.org> * upload data to gpu working Signed-off-by: Ian Chen <ichen@osrfoundation.org> * remove unused code Signed-off-by: Ian Chen <ichen@osrfoundation.org> * fix loading Signed-off-by: Ian Chen <ichen@osrfoundation.org> * style Signed-off-by: Ian Chen <ichen@osrfoundation.org>
11 tasks
Codecov Report
@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 54.16% 54.08% -0.08%
==========================================
Files 203 203
Lines 20227 20266 +39
==========================================
+ Hits 10955 10960 +5
- Misses 9272 9306 +34
Continue to review full report at Codecov.
|
iche033
approved these changes
Dec 8, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-rendering6tomainBranch comparison: main...ign-rendering6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)