Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Namespace Migration : gz-plugin #83

Merged
merged 23 commits into from
May 28, 2022
Merged

ign -> gz Namespace Migration : gz-plugin #83

merged 23 commits into from
May 28, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request May 17, 2022
Closed
8 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 17, 2022
@methylDragon methylDragon mentioned this pull request May 17, 2022
Closed
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 17, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label May 17, 2022
chapulina
chapulina approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the changed migration file and 🟢 CI

MIGRATION.md Show resolved Hide resolved
@methylDragon methylDragon force-pushed the namespace_migration branch 2 times, most recently from 1d9e268 to 5d6a873 Compare May 20, 2022 08:52
@scpeters scpeters mentioned this pull request May 23, 2022
Closed
8 tasks
@scpeters
Copy link
Member

scpeters commented May 23, 2022 •
edited
Loading

the core/include/ignition/plugin.hh file is missing

@methylDragon
Copy link
Contributor Author

the core/include/ignition/plugin.hh file is missing

I see you added the commit on the narrowed branch, the changes have been reflected here!

chapulina
chapulina approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

@methylDragon
Update header guards
b450794 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Namespace migration
5669f6b 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Add migration files
1fb0f24 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Deprecation trick
3b39a07 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Include config.hh
faf3abe 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Ticktock config macros
07f1a58 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Mention gz headers in migration
44d7d9f 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate includes to gz
04216af 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate MIGRATION
d177c19 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate Export.hh macros and deprecated test
e07d0ad 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Fix bugs
60f7418 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Greedy macro migration
f1f716a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate github links
da239f8 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Add header guards for DETAIL_GZ_PLUGIN_VISIBLE
2195751 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate user-facing Ignition to Gazebo
8e2d01e 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Include config.hh in recursive directories and <lib>.hh
23c01ec 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Gazebo Robotics -> Gazebo
4dbb3b4 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
ignitionrobotics -> gazebosim
64e934b 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Rollback osrf-migration.github.io migrations
5be024a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@chapulina
Depend on ignition-tools2
ccbf41e 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
More Gz
5d1cd2b 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Revert visibility changes
266d076 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
prevent macro redefinition
689446c 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit 5297c3e into main May 28, 2022
@chapulina chapulina deleted the namespace_migration branch May 28, 2022 20:03
@scpeters
Copy link
Member

the core/include/ignition/plugin.hh file is missing

I see you added the commit on the narrowed branch, the changes have been reflected here!

by the time this was merged, the file was lost again:

@methylDragon methylDragon mentioned this pull request May 28, 2022
Merged
@methylDragon
Copy link
Contributor Author

the core/include/ignition/plugin.hh file is missing

I see you added the commit on the narrowed branch, the changes have been reflected here!

by the time this was merged, the file was lost again:

How did that happen 🤯
#86

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methylDragon @scpeters @chapulina