Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ruby commands on windows #63

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Part of gazebosim/gz-tools#71.

Summary

Make sure to add_subdirectory(cmd) on Windows. This requires generating the .rb and .yaml files to folders unique to $<CONFIG>.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

This requires generating the .rb and .yaml files to folders
unique to $<CONFIG>.

Part of gazebosim/gz-tools#71.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #63 (06ccbae) into ign-plugin1 (e4015f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-plugin1      #63   +/-   ##
============================================
  Coverage        99.82%   99.82%           
============================================
  Files               15       15           
  Lines              584      584           
============================================
  Hits               583      583           
  Misses               1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4015f3...06ccbae. Read the comment docs.

@chapulina chapulina added the Windows Windows support label Oct 30, 2021
@scpeters scpeters merged commit 0da6f07 into gazebosim:ign-plugin1 Nov 3, 2021
@scpeters scpeters deleted the win_install_cmd branch November 3, 2021 16:17
ahcorde pushed a commit that referenced this pull request Nov 3, 2021
This requires generating the .rb and .yaml files to folders
unique to $<CONFIG>.

Part of gazebosim/gz-tools#71.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@azeey azeey mentioned this pull request Oct 23, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants