Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bazel deps to pass layering_check #143

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

mbeards
Copy link
Contributor

@mbeards mbeards commented Apr 16, 2024

🦟 Bug fix

Summary

Makes gz-plugin build successfully with layering_check and parse_headers turned on. These failures are currently only detectable in Intrinsic's internal Bazel infrastructure.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Beardsworth <beardsworth@intrinsic.ai>
@mbeards mbeards requested a review from ahcorde as a code owner April 16, 2024 16:11
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Apr 16, 2024
@shameekganguly shameekganguly self-requested a review April 16, 2024 17:28
@azeey azeey merged commit 59e79e6 into gazebosim:gz-plugin2 Apr 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants