Do not install CMakeLists.txt in loader/register #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By including the installation of a whole directory in the source code for loader/register, the buildsystem is installing the CMakeLists.txt files that are included in these directories. Exclude them from the final installation by using the EXCLUDE clause in CMake. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
By including the installation of a whole directory in the source code for loader/register, the buildsystem is installing the CMakeLists.txt files that are included in these directories. Exclude them from the final installation by using the EXCLUDE clause in CMake. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
github-actions
bot
added
🏯 fortress
ahcorde
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
By including the installation of a whole directory in the source code for loader/register, the buildsystem is installing the CMakeLists.txt files that are included in these directories. Debian packaging QA tool was complaining about it:
Exclude them from the final installation by using the EXCLUDE clause in CMake.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.