Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved install instructions #106

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Improved install instructions #106

merged 1 commit into from
Sep 13, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 13, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Fixed visualization and added a comment about the versions

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Sep 13, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #106 (f927a6c) into gz-plugin2 (c189b78) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           gz-plugin2     #106   +/-   ##
===========================================
  Coverage       98.26%   98.26%           
===========================================
  Files              23       23           
  Lines             748      748           
===========================================
  Hits              735      735           
  Misses             13       13           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit c0b12e9 into gz-plugin2 Sep 13, 2022
@mjcarroll mjcarroll deleted the ahcorde/improve/doc branch September 13, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants