3 ➡️ 4 #291
Merged
3 ➡️ 4 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added DART feature for setting joint limits dynamically. Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> * Make code compatible with older DART release (this commit can be reverted once newer DART is out). Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> * Updated the number of models for test. Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> * Apply suggestions from code review Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> Co-authored-by: Addisu Z. Taddese <addisu@gmail.com> * Fixed issues from review. Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> * Accomodate DART 6.9 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Since joints in DART are not considered frames, this adds dart::dynamics::SimpleFrame attached to the child body of a joint and offset from the child by the pose of the joint. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-physics4 #291 +/- ##
================================================
- Coverage 75.86% 75.65% -0.22%
================================================
Files 125 125
Lines 5531 5627 +96
================================================
+ Hits 4196 4257 +61
- Misses 1335 1370 +35
Continue to review full report at Codecov.
|
scpeters
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-physics3toign-physics4Branch comparison: ign-physics4...ign-physics3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸