Bumps in ionic: use gz-cmake4, gz-utils3 #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
scpeters
changed the title
scpeters
reviewed
Oct 12, 2023
src/Quaternion_TEST.cc
Outdated
| q.Axis(0, 1, 0, GZ_PI); | ||
| EXPECT_EQ(q, math::Quaterniond(6.12303e-17, 0, 1, 0)); | ||
|
|
||
| // Deprecated in gz-math7 | ||
| // Deprecated in gz-math8 |
There was a problem hiding this comment.
revert this comment change, and instead prepare to deprecate the related code
83 tasks
|
I merged the gz-utils3 pull requests and restarted the homebrew build since I think it may pass |
homebrew build is happy; I think we need nightlies of gz-utils3 next |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #562 +/- ##
==========================================
+ Coverage 94.53% 96.18% +1.64%
==========================================
Files 144 143 -1
Lines 9626 9826 +200
==========================================
+ Hits 9100 9451 +351
+ Misses 526 375 -151 |
8 tasks
scpeters
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gazebo-tooling/release-tools#1027