Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common widget GzColor (Fortress) #411

Closed
wants to merge 6 commits into from

Conversation

AzulRadio
Copy link
Contributor

New feature

Summary

Pack RGB color GUI into a common widget GzColor.qml

Replace the color GUI in GridConfig with the common widget

TODO: Also replace Lights.qml and Material.qml in component inspector

Test it

demo_gzcolor_gridconfig

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #411 (5a62bf8) into ign-gui6 (2ba68b8) will increase coverage by 35.13%.
The diff coverage is n/a.

❗ Current head 5a62bf8 differs from pull request most recent head b7f3663. Consider uploading reports for the commit b7f3663 to get more accurate results

@@              Coverage Diff              @@
##           ign-gui6     #411       +/-   ##
=============================================
+ Coverage     30.54%   65.68%   +35.13%     
=============================================
  Files            41       39        -2     
  Lines          1748     5182     +3434     
=============================================
+ Hits            534     3404     +2870     
- Misses         1214     1778      +564     
Impacted Files Coverage Δ
src/plugins/screenshot/moc_Screenshot.cpp
src/plugins/publisher/qrc_Publisher.cpp
src/plugins/scene3d/moc_Scene3D.cpp
src/plugins/grid_config/qrc_GridConfig.cpp
src/plugins/minimal_scene/moc_MinimalScene.cpp
include/ignition/gui/moc_MainWindow.cpp
src/plugins/camera_tracking/qrc_CameraTracking.cpp
src/plugins/shutdown_button/qrc_ShutdownButton.cpp
src/plugins/teleop/qrc_Teleop.cpp
src/plugins/key_publisher/moc_KeyPublisher.cpp
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba68b8...b7f3663. Read the comment docs.

@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Jun 6, 2022
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants