-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ign-fuel-tools7 ➡️ gz-fuel-tools8 #362
Conversation
* Support downloading from a referal link Signed-off-by: Nate Koenig <natekoenig@gmail.com> * spelling Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Address comments Signed-off-by: Nate Koenig <natekoenig@gmail.com> --------- Signed-off-by: Nate Koenig <natekoenig@gmail.com>
* 4.8.3 release Signed-off-by: Nate Koenig <natekoenig@gmail.com> * 4.8.3 Signed-off-by: Nate Koenig <natekoenig@gmail.com> --------- Signed-off-by: Nate Koenig <natekoenig@gmail.com>
The ModelIter iterator was fetching all available pages before making the first model available. This PR makes it so that each page is fetched from Fuel when the iterator is advanced. This also adds a new member function FuelClient::Models(onst ModelIdentifier &_id, bool _checkCache) that allows bypassing the cache when getting a list of models owned by a user from the server. --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Merge ign-fuel-tools4 ➡️ ign-fuel-tools7
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Fixes compiler warnings on macOS. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Merge ign-fuel-tools4 ➡️ ign-fuel-tools7
src/FuelClient_TEST.cc
Outdated
TEST_F(FuelClientTest, ModelsCheckCached) | ||
{ | ||
ClientConfig config; | ||
std::string cacheDir = common::joinPaths(PROJECT_BINARY_PATH, "test_cache"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be fixed since PROJECT_BINARY_PATH
is no longer in use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use common::cwd
as other tests have done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call, I just amended to cfa86f7
src/FuelClient_TEST.cc
Outdated
TEST_F(FuelClientTest, ModelsCheckCached) | ||
{ | ||
ClientConfig config; | ||
std::string cacheDir = common::joinPaths(PROJECT_BINARY_PATH, "test_cache"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use common::cwd
as other tests have done.
b683890
to
cfa86f7
Compare
Codecov Report
@@ Coverage Diff @@
## gz-fuel-tools8 #362 +/- ##
==================================================
+ Coverage 75.30% 75.32% +0.02%
==================================================
Files 20 20
Lines 2911 2910 -1
==================================================
Hits 2192 2192
+ Misses 719 718 -1
|
the windows test failures are already present on the |
➡️ Forward port
Port
ign-fuel-tools7
➡️gz-fuel-tools8
Branch comparison: gz-fuel-tools8...ign-fuel-tools7
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)