Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and fix ResultType tests #225

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

While debugging test failures on #224, I noticed that some of our ResultType tests were comparing Result objects converted to booleans instead of the result types themselves. This PR makes sure we're comparing the types and fixes some test expectations.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the tests Broken or missing tests / testing infra label Dec 29, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Dec 29, 2021
@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #225 (ba7cf87) into ign-fuel-tools4 (4edeed5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-fuel-tools4     #225   +/-   ##
================================================
  Coverage            77.90%   77.90%           
================================================
  Files                   19       19           
  Lines                 2715     2715           
================================================
  Hits                  2115     2115           
  Misses                 600      600           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4edeed5...ba7cf87. Read the comment docs.

@chapulina chapulina merged commit e88d5e6 into ign-fuel-tools4 Jan 10, 2022
@chapulina chapulina deleted the chapulina/4/resulttype branch January 10, 2022 20:33
chapulina added a commit that referenced this pull request Mar 7, 2022
* Improve and fix ResultType tests (#225)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Move test cache to build folder (#222)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* More checks when manipulating file system in tests (#227)

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants