Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GoogleTest to latest version #361

Merged
merged 6 commits into from
Jun 28, 2022
Merged

Update GoogleTest to latest version #361

merged 6 commits into from
Jun 28, 2022

Conversation

mjcarroll
Copy link
Contributor

Import latest version of GoogleTest from upstream and adjust build accordingly.

Signed-off-by: Michael Carroll michael@openrobotics.org

@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 31, 2022
@chapulina chapulina added the tests Broken or missing tests / testing infra label May 31, 2022
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #361 (91a82ee) into main (22e0f02) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   77.94%   77.83%   -0.11%     
==========================================
  Files          84       85       +1     
  Lines       10756    10771      +15     
==========================================
  Hits         8384     8384              
- Misses       2372     2387      +15     
Impacted Files Coverage Δ
graphics/include/gz/common/Material.hh 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e0f02...91a82ee. Read the comment docs.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
test/CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Michael Carroll <michael@openrobotics.org>

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@mjcarroll mjcarroll merged commit 4416bee into main Jun 28, 2022
@mjcarroll mjcarroll deleted the bump_gtest branch June 28, 2022 21:31
luca-della-vedova pushed a commit that referenced this pull request Jul 27, 2022
* Remove old gtest version
* Add new vendored Googletest version
* CMake updates for new googletest version
* Remove all gtest_main functions
* Update test/CMakeLists.txt

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants