Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests for parentPath/basename #309

Merged
merged 6 commits into from
Mar 3, 2022

Conversation

mjcarroll
Copy link
Contributor

Verify the behavior of parentPath and basename in ign-common4 to assert that #308 is correct.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll self-assigned this Feb 10, 2022
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Feb 10, 2022
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #309 (918e8d4) into ign-common4 (bde2937) will not change coverage.
The diff coverage is n/a.

❗ Current head 918e8d4 differs from pull request most recent head 20c0154. Consider uploading reports for the commit 20c0154 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common4     #309   +/-   ##
============================================
  Coverage        77.02%   77.02%           
============================================
  Files               76       76           
  Lines            10729    10729           
============================================
  Hits              8264     8264           
  Misses            2465     2465           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bde2937...20c0154. Read the comment docs.

src/Filesystem_TEST.cc Outdated Show resolved Hide resolved
@chapulina chapulina added the tests Broken or missing tests / testing infra label Mar 3, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with happy CI.

Note that the absolute parentPath test is having different results for Windows on this branch and on main with #308

  • Here: EXPECT_EQ(parentPath(absolute), "home\\bob")
  • On main: EXPECT_EQ(parentPath(absolute), "\\home\\bob")

If we consider the behaviour on this branch to be correct (since it's a stable version), then a fix should go into main later. Otherwise, if we think this branch is wrong, we could change the behaviour here and document it in the migration guide (but that may affect users).

@chapulina chapulina enabled auto-merge (squash) March 3, 2022 17:39
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit ad0fc88 into ign-common4 Mar 3, 2022
@chapulina chapulina deleted the characterize_parentPath branch March 3, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants