Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert geospatial component for now #291

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Reverts #267 and #289 for now to unbreak ign-rendering (see gazebosim/gz-rendering#539 (comment) )

Summary

I suggested to @jennuine that we were ready to merge #267 but I didn't think about how it would break ign-rendering, so I suggest that we revert the changes for now.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This reverts commit e0a5490.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This reverts commit 28eb6c7.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #291 (4548421) into main (e0a5490) will decrease coverage by 0.27%.
The diff coverage is n/a.

❗ Current head 4548421 differs from pull request most recent head da536ed. Consider uploading reports for the commit da536ed to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
- Coverage   76.69%   76.42%   -0.28%     
==========================================
  Files          76       75       -1     
  Lines       10647    10461     -186     
==========================================
- Hits         8166     7995     -171     
+ Misses       2481     2466      -15     
Impacted Files Coverage Δ
graphics/include/ignition/common/HeightmapData.hh 100.00% <ø> (ø)
graphics/include/ignition/common/ImageHeightmap.hh 88.88% <ø> (ø)
graphics/src/ImageHeightmap.cc 55.55% <ø> (ø)
src/Util.cc 84.00% <0.00%> (-2.50%) ⬇️
graphics/src/Image.cc 69.14% <0.00%> (-1.57%) ⬇️
src/SystemPaths.cc 86.08% <0.00%> (-0.44%) ⬇️
graphics/src/Dem.cc

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a5490...da536ed. Read the comment docs.

@mjcarroll mjcarroll merged commit 68ba882 into gazebosim:main Jan 19, 2022
@scpeters scpeters deleted the revert_geospatial branch January 21, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants