Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload coverage for Focal builds #284

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Upload coverage for Focal builds #284

merged 5 commits into from
Jan 5, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

When we dropped Bionic on #270 , we should have enabled test coverage for Focal. Right now we have no coverage reports on main 😬

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added tests Broken or missing tests / testing infra 🌱 garden Ignition Garden labels Dec 24, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #284 (6ac8585) into main (ee37636) will decrease coverage by 0.65%.
The diff coverage is 66.99%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   77.08%   76.42%   -0.66%     
==========================================
  Files          75       75              
  Lines       10683    10461     -222     
==========================================
- Hits         8235     7995     -240     
- Misses       2448     2466      +18     
Impacted Files Coverage Δ
graphics/include/ignition/common/Image.hh 97.05% <ø> (ø)
graphics/src/NodeTransform.cc 59.09% <0.00%> (ø)
include/ignition/common/Filesystem.hh 100.00% <ø> (ø)
include/ignition/common/WorkerPool.hh 100.00% <ø> (ø)
src/Timer.cc 0.00% <ø> (-60.00%) ⬇️
graphics/src/ImageHeightmap.cc 55.55% <14.28%> (-32.91%) ⬇️
src/Battery.cc 93.69% <33.33%> (-5.38%) ⬇️
graphics/src/SVGLoader.cc 86.67% <66.66%> (-0.16%) ⬇️
graphics/include/ignition/common/ImageHeightmap.hh 88.88% <88.88%> (ø)
src/URI.cc 97.12% <88.88%> (-0.29%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06226f6...6ac8585. Read the comment docs.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@mjcarroll mjcarroll merged commit be3aa32 into main Jan 5, 2022
@mjcarroll mjcarroll deleted the chapulina/5/focal_cov branch January 5, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants