Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely rely on packages.apt from Garden #709

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Apr 15, 2022

Building on top of @methylDragon 's work in:

This PR completely skips all dependency resolution for Garden versions. We should probably be able to change this all the way back to Citadel, but for now sticking to Garden to be quicker.

Builds have been installing more than they needed for a while, but it hasn't been a problem until now because all libraries could be installed side-by-side. But while we work on #698, ign-tools2 will be conflicting with ign-tools1 for a while. So it's especially important that we only install what we need, as described on packages.apt.

➡️ I recommend hiding whitespace changes for easier review

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

YOLO merging to unblock #685

🙏🏽 🤞🏽

@chapulina chapulina merged commit 5f43d79 into master Apr 15, 2022
@chapulina chapulina deleted the chapulina/archive_garden branch April 15, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant