Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use credential bindings for osrfbuild github token #353

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Use credential bindings for osrfbuild github token #353

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e939585
Use credential bindings for osrfbuild github token
j-rivero Dec 4, 2020
f2a26b0
Refactor Github Credential bindings to use in test job
j-rivero Feb 23, 2021
6b10931
Fix syntax
j-rivero Feb 23, 2021
bc5e095
crendtialBindings work on wrappers context
j-rivero Feb 23, 2021
8a346e4
Fix username
j-rivero Feb 23, 2021
2a446d3
Use lower class
j-rivero Feb 23, 2021
0bd6790
Change job name
j-rivero Feb 23, 2021
cbbf481
Use crendentials for ssh keys
j-rivero Feb 23, 2021
733e4d1
Use ssh-agent
j-rivero Feb 23, 2021
0808e84
Fix syntax
j-rivero Feb 23, 2021
56e83f2
Key management should not be needed if using token
j-rivero Feb 23, 2021
cf1a678
Move token to auxiliary class
j-rivero Feb 25, 2021
69bd5c1
Implement API check for permissions
j-rivero Feb 25, 2021
20551f3
Check for permissions using a temporary branch
j-rivero Feb 25, 2021
cc1cc08
Run the job on Linux
j-rivero Feb 25, 2021
2c5ac8a
Update test
j-rivero Feb 25, 2021
2f83bee
Use GITHUB_TOKEN in git push
j-rivero Feb 26, 2021
0693a38
Fix DSL
j-rivero Feb 26, 2021
79ac87c
Run job on osx nodes
j-rivero Jun 3, 2021
25f2012
Do not need to run jobs on master
j-rivero Oct 11, 2021
3df462d
Merge branch 'master' into osrfbuild_credential_binding
scpeters Oct 11, 2021
f739238
Merge branch 'master' into osrfbuild_credential_binding
j-rivero Dec 7, 2023
65a5967
Back to run jobs on master
j-rivero Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions jenkins-scripts/dsl/brew_release.dsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ release_job.with
'Version of the package just released')
stringParam('SOURCE_TARBALL_SHA','',
'SHA Hash of the tarball file')
credentialsBinding {
// credential name needs to be in sync with provision code at infra/osrf-chef repo
string('GITHUB_TOKEN', 'osrfbuild-token')
}
}

steps
Expand Down Expand Up @@ -254,9 +258,13 @@ bottle_job_hash_updater.with

parameters
{
// reuse the pull request created by homebrew_pull_request_updater in step 1
stringParam("PULL_REQUEST_URL", '',
'Pull request URL (osrf/homebrew-simulation) pointing to a pull request.')
// reuse the pull request created by homebrew_pull_request_updater in step 1
stringParam("PULL_REQUEST_URL", '',
'Pull request URL (osrf/homebrew-simulation) pointing to a pull request.')
credentialsBinding {
// credential name needs to be in sync with provision code at infra/osrf-chef repo
string('GITHUB_TOKEN', 'osrfbuild-token')
}
}

steps
Expand Down
12 changes: 0 additions & 12 deletions jenkins-scripts/lib/_homebrew_github_setup.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,6 @@ if [[ -z $(ssh -T git@github.com 2>&1 | grep successfully) ]]; then
exit 1
fi

GITHUB_TOKEN_FILE="/var/lib/jenkins/.github_token"
if [[ ! -f ${GITHUB_TOKEN_FILE} ]]; then
echo "The hub cli tool needs a valid token at file ${GITHUB_TOKEN_FILE}"
echo "The file was not found"
exit 1
fi

set +x # keep password secret
export GITHUB_TOKEN=`cat $GITHUB_TOKEN_FILE`
set -x # back to debug
echo '# END SECTION'

echo '# BEGIN SECTION: download linuxbrew'
/bin/bash -c "$(curl -fsSL https://github.com/raw/Homebrew/install/master/install.sh)"
echo '# END SECTION'
Expand Down