Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace /usr/local with HOMEBREW_PREFIX #1190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scpeters
Copy link
Contributor

One of our brew build scripts has a HOMEBREW_PREFIX variable to represent the location where brew is installed (either /usr/local for Intel macOS machines or /opt/homebrew for arm macOS machines), but it also has many paths hard-coded to /usr/local. In preparation for supporting arm-based CI machines, use the HOMEBREW_PREFIX variable more widely.

One of our brew build scripts has a HOMEBREW_PREFIX
variable, but it also has many paths hard-coded to
/usr/local. In preparation for supporting arm-based
CI machines that use brew from /opt/homebrew, use
the HOMEBREW_PREFIX variable more widely.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Copy link
Contributor

@claraberendsen claraberendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scpeters for setting this up! A quick question related to the name of the bash script ... since we are generalizing it, would it make sense to update the name to be project-default-devel-homebrew.bash?
I'm not sure if there are more particularities in the script that would make keeping the amd64 naming still worth it.

@scpeters
Copy link
Contributor Author

Thanks @scpeters for setting this up! A quick question related to the name of the bash script ... since we are generalizing it, would it make sense to update the name to be project-default-devel-homebrew.bash? I'm not sure if there are more particularities in the script that would make keeping the amd64 naming still worth it.

I'm fine with changing the name of the script, though it's not quite generalized yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants