Skip to content

Commit

Permalink
Do not integrate all brew pr_any job with all branches (#1061)
Browse files Browse the repository at this point in the history
Remove the workaround since it won't work with ign- jobs generated for Citadel in modern branches since there is no ign- formulas anymore.

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
  • Loading branch information
j-rivero authored Nov 7, 2023
1 parent cfa04bd commit da4fd32
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions jenkins-scripts/dsl/gazebo_libs.dsl
Original file line number Diff line number Diff line change
Expand Up @@ -254,14 +254,10 @@ ciconf_per_lib_index.each { lib_name, lib_configs ->
// --------------------------------------------------------------
def gz_brew_ci_any_job_name = "${gz_job_name_prefix}-ci-pr_any-homebrew-amd64"
def gz_brew_ci_any_job = job(gz_brew_ci_any_job_name)
// TODO: Instead of GITHUB_SUPPORT_ALL_BRANCHES the right configuration would be $branch_names
// leave all the branches since we only support one brew platform and it covers the
// cases of PRs targeting not stable branches, see:
// https://github.com/gazebo-tooling/release-tools/issues/1044
OSRFBrewCompilationAnyGitHub.create(gz_brew_ci_any_job,
"gazebosim/${lib_name}",
is_testing_enabled(lib_name, ci_config),
GITHUB_SUPPORT_ALL_BRANCHES,
branch_names,
ENABLE_GITHUB_PR_INTEGRATION,
are_cmake_warnings_enabled(lib_name, ci_config))
gz_brew_ci_any_job.with
Expand Down

0 comments on commit da4fd32

Please sign in to comment.