Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable branches for gz-rendering8 and sdformat14 #68

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 29, 2023

No description provided.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from iche033 August 29, 2023 19:40
@iche033
Copy link
Contributor

iche033 commented Aug 29, 2023

should the entries be removed or changed to prerelease? Asking because I saw that's done in #35

@azeey
Copy link
Contributor Author

azeey commented Aug 29, 2023

I think we need to do that for anything downstream, but AFAIK gz-rendering and sdformat don't depend on anything that has been bumped in Harmonic, so they can just use stable.

@iche033
Copy link
Contributor

iche033 commented Aug 29, 2023

got it

@azeey azeey merged commit 3b5eac8 into master Aug 29, 2023
2 checks passed
@azeey azeey deleted the azeey/rendering_sdformat_stable branch August 29, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants