fix(gatsby-telemetry): reduce save to config

[wardpeet]

Description

We write machineId to disk every time we try to request it, even if it's already there.
On windows I get

Error: EPERM: operation not permitted, rename '<HOME>.config\gatsby\config.json.2888574204' -> '<HOME>.config\gatsby\config.json'
    at Object.renameSync (fs.js:772:3)
    at Function.writeFileSync [as sync] (<ROOTDIR>gatsby\tmp\gatsby-tmp-ssr\node_modules\write-file-atomic\index.js:244:8)
    at Configstore.set all [as all] (<ROOTDIR>gatsby\tmp\gatsby-tmp-ssr\node_modules\configstore\index.js:61:20)
    at Configstore.set (<ROOTDIR>gatsby\tmp\gatsby-tmp-ssr\node_modules\configstore\index.js:91:12)
    at EventStorage.updateConfig (<ROOTDIR>gatsby\tmp\gatsby-tmp-ssr\node_modules\gatsby-telemetry\lib\event-storage.js:124:24)
    at AnalyticsTracker.getMachineId (<ROOTDIR>gatsby\tmp\gatsby-tmp-ssr\node_modules\gatsby-telemetry\lib\telemetry.js:335:16)
    at new AnalyticsTracker (<ROOTDIR>gatsby\tmp\gatsby-tmp-ssr\node_modules\gatsby-telemetry\lib\telemetry.js:76:27)
    at Object.<anonymous> (<ROOTDIR>gatsby\tmp\gatsby-tmp-ssr\node_modules\gatsby-telemetry\lib\index.js:37:18)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (<ROOTDIR>gatsby\tmp\gatsby-tmp-ssr\node_modules\gatsby\src\redux\index.ts:10:1)

Documentation

Related Issues