feat(gatsby): enable async rendering with react 18 #32188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
topic: frontend
wardpeet
force-pushed
the
feat/react-async-rendering
branch
from
d7cb34c
to
e744840
Compare
wardpeet
commented
Jul 1, 2021
| @@ -234,7 +234,7 @@ const renderHTMLQueue = async ( | |||
| payload: pageSegment, | |||
| }) | |||
|
|
|||
| for (const [_pagePath, arrayOfUsages] of Object.entries( | |||
| for (const [, arrayOfUsages] of Object.entries( | |||
wardpeet
force-pushed
the
feat/react-async-rendering
branch
from
8faee2f
to
7f84656
Compare
wardpeet
force-pushed
the
feat/async-browser
branch
from
7e277cd
to
ff585df
Compare
wardpeet
force-pushed
the
feat/react-async-rendering
branch
from
9cf528f
to
5211f56
Compare
vladar
reviewed
Jul 1, 2021
| onCompleteAll() { | ||
| startWriting() | ||
| }, | ||
| onError() {}, |
There was a problem hiding this comment.
Do we want to ignore errors here?
There was a problem hiding this comment.
we won't do streaming yet until libs have adopted and maybe we never do.
React still throws the error so this is just to don't show the warning.
vladar
previously approved these changes
Jul 1, 2021
wardpeet
force-pushed
the
feat/react-async-rendering
branch
from
5211f56
to
8b8623e
Compare
wardpeet
force-pushed
the
feat/react-async-rendering
branch
from
8b8623e
to
b8f9937
Compare
wardpeet
force-pushed
the
feat/react-async-rendering
branch
from
b8f9937
to
cc09599
Compare
vladar
approved these changes
Jul 2, 2021
wardpeet
added
the
bot: merge on green
vladar
pushed a commit
that referenced
this pull request
Jul 6, 2021
* feat(gatsby): enable replaceRenderer to be async * update tests * duplicated apiRunner for better results * enable async in everything * SAVEPOINT * fix error parsgin * remove console.log * fix tests * add sync test * enable async rendering * remove debug info * fix async * remove debug (cherry picked from commit 32e9b4a)
vladar
added a commit
that referenced
this pull request
Jul 6, 2021
* feat(gatsby): enable replaceRenderer to be async * update tests * duplicated apiRunner for better results * enable async in everything * SAVEPOINT * fix error parsgin * remove console.log * fix tests * add sync test * enable async rendering * remove debug info * fix async * remove debug (cherry picked from commit 32e9b4a) Co-authored-by: Ward Peeters <ward@coding-tech.com> Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable Async rendering like Suspense during SSR.
pipeToNodeWritableis a stream rendering that support Suspense boundaries and works with the new createRoot/hydrateRoot APIs.reactwg/react-18#22
After ssr:
During client side navigation:
