Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update query-filters-sort benchmark #32163

Merged
merged 1 commit into from
Jun 30, 2021
Merged

chore: update query-filters-sort benchmark #32163

merged 1 commit into from
Jun 30, 2021

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Jun 29, 2021

Description

There were several issues with query-filters-sort benchmark:

  1. It was fetching only 5 items - switched to 100 for more realistic results
  2. Disabled schema inference as it is unrelated to what this benchmark is measuring but takes time
  3. Switched to random text because apparently, v8 is smart enough to deduplicate huge chunks of identical text, so the previous approach for TEXT parameter was useless

Plus did some cleanup there

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 29, 2021
@vladar vladar removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 29, 2021
@LekoArts LekoArts merged commit 6c1a1d9 into master Jun 30, 2021
@LekoArts LekoArts deleted the vladar/update-benchmark branch June 30, 2021 07:32
This was referenced Jul 28, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladar @LekoArts